Support streaming log to the end for get_log API
#54552
Draft
+70
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related:
Why
The
get_logAPI with theapplication/nd-jsonheader should stream logs to the end, but theFileTaskHandlercan only read content that has already been flushed to the file and cannot access content that is still being written.What
There should be a polling mechanism to check for new changes to the file so that the API connection can remain open for streaming content to the frontend.
stream_file_until_closewithpoll_interval = 0.1andidle_timeout = 10.0seconds to keep streaming the file content until it remains unchanged for longer than theidle_timeoutthreshold._interleave_logsso that logs are flushed based on a time interval, even if the heap size doesn't reachHEAP_DUMP_SIZE, to prevent frontend display delays.log_posfrom log metadata.LogStreamAccumulatorso that the API can raise log records as soon as possible.LogStreamAccumulatorflushes the log stream to a temp file to get the total log lines for the frontend, it requires waiting until the log stream ends before it can replay the log stream.Example Dag for Testing the
get_logAPI Streaming Results